-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Reduce Searchable Snapshots IndexInput resource descriptions #68968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywelsch
approved these changes
Feb 15, 2021
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
Author
|
Thanks Yannick |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Feb 16, 2021
…#68968) We noticed that the resource descriptions of the IndexInput used for Searchable Snapshots can grow pretty large. This is due to the fact that resource descriptions tend to aggregate all kind of information, maybe more than really useful, and also that description of slices are based on the toString() computation rather than just picking up the parent's index input description. This pull request reduces the length of the description at various places.
tlrx
added a commit
that referenced
this pull request
Feb 16, 2021
We noticed that the resource descriptions of the IndexInput used for Searchable Snapshots can grow pretty large. This is due to the fact that resource descriptions tend to aggregate all kind of information, maybe more than really useful, and also that description of slices are based on the toString() computation rather than just picking up the parent's index input description. This commit reduces the length of the description at various places. Backport of #68968
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 1, 2021
…#68968) We noticed that the resource descriptions of the IndexInput used for Searchable Snapshots can grow pretty large. This is due to the fact that resource descriptions tend to aggregate all kind of information, maybe more than really useful, and also that description of slices are based on the toString() computation rather than just picking up the parent's index input description. This pull request reduces the length of the description at various places.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 1, 2021
…#68968) We noticed that the resource descriptions of the IndexInput used for Searchable Snapshots can grow pretty large. This is due to the fact that resource descriptions tend to aggregate all kind of information, maybe more than really useful, and also that description of slices are based on the toString() computation rather than just picking up the parent's index input description. This pull request reduces the length of the description at various places.
tlrx
added a commit
that referenced
this pull request
Mar 1, 2021
…#69683) We noticed that the resource descriptions of the IndexInput used for Searchable Snapshots can grow pretty large. This is due to the fact that resource descriptions tend to aggregate all kind of information, maybe more than really useful, and also that description of slices are based on the toString() computation rather than just picking up the parent's index input description. This pull request reduces the length of the description at various places.
tlrx
added a commit
that referenced
this pull request
Mar 1, 2021
…#69681) We noticed that the resource descriptions of the IndexInput used for Searchable Snapshots can grow pretty large. This is due to the fact that resource descriptions tend to aggregate all kind of information, maybe more than really useful, and also that description of slices are based on the toString() computation rather than just picking up the parent's index input description. This commit reduces the length of the description at various places. Backport of #68968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>non-issue
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.11.2
v7.12.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the resource descriptions of the IndexInput used for Searchable Snapshots can grow pretty large. This is due to the fact that resource descriptions tend to aggregate all kind of information, maybe more than really useful, and also that description of slices are based on the toString() computation rather than just picking up the parent's index input description.
This pull request reduces the length of the description at various places.