Skip to content

Conversation

@tlrx
Copy link
Member

@tlrx tlrx commented Feb 15, 2021

We noticed that the resource descriptions of the IndexInput used for Searchable Snapshots can grow pretty large. This is due to the fact that resource descriptions tend to aggregate all kind of information, maybe more than really useful, and also that description of slices are based on the toString() computation rather than just picking up the parent's index input description.

This pull request reduces the length of the description at various places.

@tlrx tlrx requested a review from ywelsch February 15, 2021 08:59
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Feb 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx tlrx merged commit 9d1b2a5 into elastic:master Feb 16, 2021
@tlrx tlrx deleted the reduce-resource-desc branch February 16, 2021 08:20
@tlrx
Copy link
Member Author

tlrx commented Feb 16, 2021

Thanks Yannick

tlrx added a commit to tlrx/elasticsearch that referenced this pull request Feb 16, 2021
…#68968)

We noticed that the resource descriptions of the IndexInput
used for Searchable Snapshots can grow pretty large. This
is due to the fact that resource descriptions tend to
aggregate all kind of information, maybe more than really
useful, and also that description of slices are based on the
toString() computation rather than just picking up the
parent's index input description.

This pull request reduces the length of the description at
various places.
tlrx added a commit that referenced this pull request Feb 16, 2021
We noticed that the resource descriptions of the IndexInput
used for Searchable Snapshots can grow pretty large. This
is due to the fact that resource descriptions tend to
aggregate all kind of information, maybe more than really
useful, and also that description of slices are based on the
toString() computation rather than just picking up the
parent's index input description.

This commit reduces the length of the description at
various places.

Backport of #68968
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Mar 1, 2021
…#68968)

We noticed that the resource descriptions of the IndexInput 
used for Searchable Snapshots can grow pretty large. This 
is due to the fact that resource descriptions tend to 
aggregate all kind of information, maybe more than really 
useful, and also that description of slices are based on the 
toString() computation rather than just picking up the 
parent's index input description.

This pull request reduces the length of the description at 
various places.
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Mar 1, 2021
…#68968)

We noticed that the resource descriptions of the IndexInput 
used for Searchable Snapshots can grow pretty large. This 
is due to the fact that resource descriptions tend to 
aggregate all kind of information, maybe more than really 
useful, and also that description of slices are based on the 
toString() computation rather than just picking up the 
parent's index input description.

This pull request reduces the length of the description at 
various places.
tlrx added a commit that referenced this pull request Mar 1, 2021
…#69683)

We noticed that the resource descriptions of the IndexInput 
used for Searchable Snapshots can grow pretty large. This 
is due to the fact that resource descriptions tend to 
aggregate all kind of information, maybe more than really 
useful, and also that description of slices are based on the 
toString() computation rather than just picking up the 
parent's index input description.

This pull request reduces the length of the description at 
various places.
tlrx added a commit that referenced this pull request Mar 1, 2021
…#69681)

We noticed that the resource descriptions of the IndexInput 
used for Searchable Snapshots can grow pretty large. This 
is due to the fact that resource descriptions tend to 
aggregate all kind of information, maybe more than really 
useful, and also that description of slices are based on the 
toString() computation rather than just picking up the 
parent's index input description.

This commit reduces the length of the description at 
various places.

Backport of #68968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.11.2 v7.12.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants