Indices segments: bg serialize, make cancellable #68965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response to an `IndicesSegmentsAction` might be large, perhaps 10s of MBs of JSON, and today it is serialized on a transport thread. It also might take so long to respond that the client times out, resulting in the work needed to compute the response being wasted. This commit introduces the `DispatchingRestToXContentListener` which dispatches the work of serializing an `XContent` response to a non-transport thread, and also makes `TransportBroadcastByNodeAction` sensitive to the cancellability of its tasks. It uses these two features to make the `RestIndicesSegmentsAction` serialize its response on a `MANAGEMENT` thread, and to abort its work more promptly if the client's channel is closed before the response is sent.
DaveCTurner
added
>enhancement
:Distributed Indexing/Engine
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
…d-dispatch-serialization
DaveCTurner
deleted the
2021-02-12-indices-segments-cancellable-and-dispatch-serialization
branch
DaveCTurner
added a commit
that referenced
this pull request
Feb 16, 2021
The response to an `IndicesSegmentsAction` might be large, perhaps 10s of MBs of JSON, and today it is serialized on a transport thread. It also might take so long to respond that the client times out, resulting in the work needed to compute the response being wasted. This commit introduces the `DispatchingRestToXContentListener` which dispatches the work of serializing an `XContent` response to a non-transport thread, and also makes `TransportBroadcastByNodeAction` sensitive to the cancellability of its tasks. It uses these two features to make the `RestIndicesSegmentsAction` serialize its response on a `MANAGEMENT` thread, and to abort its work more promptly if the client's channel is closed before the response is sent.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 16, 2021
A small followup to elastic#67413 and elastic#68965: the underlying actions of the `GET /_cat/segments` API are now cancellable, so we may as well cancel them if needed.
DaveCTurner
added a commit
that referenced
this pull request
Feb 16, 2021
DaveCTurner
added a commit
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response to an
IndicesSegmentsActionmight be large, perhaps 10sof MBs of JSON, and today it is serialized on a transport thread. It
also might take so long to respond that the client times out, resulting
in the work needed to compute the response being wasted.
This commit introduces the
DispatchingRestToXContentListenerwhichdispatches the work of serializing an
XContentresponse to anon-transport thread, and also makes
TransportBroadcastByNodeActionsensitive to the cancellability of its tasks.
It uses these two features to make the
RestIndicesSegmentsActionserialize its response on a
MANAGEMENTthread, and to abort its workmore promptly if the client's channel is closed before the response is
sent.