[DOCS] Edits ML hyperparameter descriptions #68880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
Team:ML
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Contributor
dimitris-athanasiou
left a comment
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM Much nicer wording!
docs/reference/ml/ml-shared.asciidoc
Outdated
| quickly. This parameter affects loss calculations by acting as a multiplier of | ||
| the tree depth. Higher alpha values result in shallower trees and faster | ||
| training times. | ||
| //TBD: but potentially reduce accuracy? |
Contributor
There was a problem hiding this comment.
Unfortunately this is quite nuanced and very much data-dependent. I think we might be better off without mentioning anything more here for now. @valeriy42 is working on an example notebook that goes into more detail on explaining hyperparameters. When that is ready we can probably link to that for users that want to delve into the more nuanced details.
Contributor
Author
There was a problem hiding this comment.
Sounds good to me, thanks! I'll remove that TBD
szabosteve
approved these changes
Feb 11, 2021
Contributor
szabosteve
left a comment
szabosteve
left a comment
There was a problem hiding this comment.
Thanks for these changes. LGTM!
lcawl
added a commit
to lcawl/elasticsearch
that referenced
this pull request
Feb 11, 2021
lcawl
added a commit
that referenced
this pull request
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #67950 and elastic/kibana#90738
This PR edits the descriptions of the machine learning data frame analytics hyperparameters, which are used in several APIs.