Add automatic tiebreaker for search requests that use a PIT #68833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the special `_shard_doc` sort tiebreaker automatically to any search requests that use a PIT. Adding the tiebreaker ensures that any sorted query can be paginated consistently within a PIT. Closes elastic#56828
jimczi
added
>feature
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
docs/reference/search/search-your-data/paginate-search-results.asciidoc
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/SearchRequest.java
Outdated
Show resolved
Hide resolved
docs/reference/search/search-your-data/paginate-search-results.asciidoc
Outdated
Show resolved
Hide resolved
mayya-sharipova
approved these changes
Feb 10, 2021
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@jimczi Thanks Jim, exciting change!
May be we can also add a note to the issue of possible future steps that we discussed offline:
- don't add sort on _score for constant score queries
- add sort on date desc for data streams etc.
astefan
reviewed
Feb 11, 2021
docs/reference/search/search-your-data/paginate-search-results.asciidoc
Outdated
Show resolved
Hide resolved
mayya-sharipova
approved these changes
Feb 17, 2021
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@jimczi Thanks for the new changes, this PR lgtm with the new changes as well
jimczi
added a commit
that referenced
this pull request
Feb 18, 2021
This PR adds the special `_shard_doc` sort tiebreaker automatically to any search requests that use a PIT. Adding the tiebreaker ensures that any sorted query can be paginated consistently within a PIT. Closes #56828
This was referenced Feb 22, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the special
_shard_docsort tiebreaker automatically to anysearch requests that use a PIT. Adding the tiebreaker ensures that any
sorted query can be paginated consistently within a PIT.
Closes #56828