Skip to content

Fix testListenersNotifiedOnCorrectThreads #68805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Fix testListenersNotifiedOnCorrectThreads #68805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions server/src/test/java/org/elasticsearch/action/support/ListenableActionFutureTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ protected void doRun() {
}
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/68772")
public void testListenersNotifiedOnCorrectThreads() throws InterruptedException {

final int adderThreads = between(1, 5);
Expand All @@ -90,7 +89,10 @@ public void testListenersNotifiedOnCorrectThreads() throws InterruptedException
awaitSafe(barrier);

final AtomicBoolean isComplete = new AtomicBoolean();
if (postComplete.get()) {
if (completerThreads == 1 && postComplete.get()) {
// If there are multiple completer threads then onResponse might return on one thread, and hence postComplete is
// set, before the other completer thread notifies all the listeners. OTOH with one completer thread we know that
// postComplete indicates that the listeners were already notified.
future.addListener(new ActionListener<>() {
@Override
public void onResponse(Void response) {
Expand Down