Skip to content

Remove Dead Test Code Branch in SparseFileTrackerTests #68801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

Remove Dead Test Code Branch in SparseFileTrackerTests #68801

merged 1 commit into from
Feb 10, 2021

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Feb 10, 2021

This branch makes no sense and was failing for the start == 0 case
now that we assert that byte ranges are well formed.

@original-brownbear
Remove Dead Test Code Branch in SparseFileTrackerTests
399cfec 
This branch makes no sense and was failing for the `start == 0` case
now that we assert that byte ranges are well formed.
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.12.0 labels Feb 10, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Feb 10, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 10, 2021

Pinging @elastic/es-distributed (Team:Distributed)

tlrx
tlrx approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Armin

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Feb 10, 2021

Thanks Tanguy! :)

@original-brownbear original-brownbear merged commit 2bc171a into elastic:master Feb 10, 2021
@original-brownbear original-brownbear deleted the remove-irrelevant-test-branch branch February 10, 2021 08:11
@original-brownbear original-brownbear mentioned this pull request Feb 10, 2021
Merged
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Feb 10, 2021
@original-brownbear
Remove Dead Test Code Branch in SparseFileTrackerTests (elastic#68801)
05bd074 
This branch makes no sense and was failing for the `start == 0` case
now that we assert that byte ranges are well formed.
original-brownbear added a commit that referenced this pull request Feb 10, 2021
@original-brownbear
Remove Dead Test Code Branch in SparseFileTrackerTests (#68801) (#68804)
861944e 
This branch makes no sense and was failing for the `start == 0` case
now that we assert that byte ranges are well formed.
@original-brownbear original-brownbear restored the remove-irrelevant-test-branch branch April 18, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrx tlrx tlrx approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.12.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@original-brownbear @elasticmachine @tlrx @jakelandis