Skip to content

Conversation

@bpintea
Copy link
Contributor

@bpintea bpintea commented Feb 9, 2021

The upstream master merge applied a few Arrays#asList to one test class,
RestSqlTestCase; the method has been statically imported in previous PR
in the branch (and Arrays class import removed), since asList is used
up to four times on one line, in some tests.

This adjusts the automatically merged in code, changing it to use the static
import.

The upstream master merge applied a few Arrays.asList to onen class,
RestSqlTestCase; the method has been statically imported in previous PR
in the branch (and class Arrays import removed), since `asList` is used
up to four times on a line, in some tests.

This adjusts the merged in code.
@bpintea bpintea marked this pull request as ready for review February 9, 2021 20:07
@bpintea bpintea merged commit 64b1287 into elastic:feat/sql-multivalue Feb 9, 2021
@bpintea bpintea deleted the fix/apply_static_aslist branch February 9, 2021 20:07
@bpintea bpintea added :Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests labels Feb 9, 2021
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Feb 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/SQL SQL querying Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants