Fix testDeleteActionDeletesSearchableSnapshot #68751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could happen for ILM to run so fast the test did not get to pick up the snapshot name from the ILM exeuction state. This changes the implementation of the test to not rely on that snapshot name, but to assert that the test repository is empty after ILM completes the cycle for the first generation backing index.
andreidan
added
>test
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Contributor
Author
|
@elasticmachine update branch |
…earchableSnapshot
dakrone
approved these changes
Feb 9, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking a look at this
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Feb 11, 2021
It could happen for ILM to run so fast the test did not get to pick up the snapshot name from the ILM execution state. This changes the implementation of the test to not rely on that snapshot name, but to assert that the test repository is empty after ILM completes the cycle for the first generation backing index. (cherry picked from commit 0c1d799) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Feb 11, 2021
It could happen for ILM to run so fast the test did not get to pick up the snapshot name from the ILM execution state. This changes the implementation of the test to not rely on that snapshot name, but to assert that the test repository is empty after ILM completes the cycle for the first generation backing index. (cherry picked from commit 0c1d799) Signed-off-by: Andrei Dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could happen for ILM to run so fast the test doesn't get to pick up
the snapshot name from the ILM execution state.
This changes the implementation of the test to not rely on that snapshot
name, but to assert that the test repository is empty after ILM completes
the cycle for the first generation backing index.