Skip to content

Conversation

@danhermann
Copy link
Contributor

Relates to #68542

@danhermann danhermann added >test Issues or PRs that are addressing/adding tests v7.12.0 v7.11.1 labels Feb 9, 2021
@danhermann danhermann requested a review from gwbrown February 9, 2021 12:06
@droberts195
Copy link

I think there was a problem with the workaround, so these tests will probably fail if unmuted. The Java security manager blocks reading /proc/meminfo - see for example https://gradle-enterprise.elastic.co/s/6qtcnglfzfdvg/tests/:server:test/org.elasticsearch.monitor.os.OsProbeTests/testGetTotalMemoryOnDebian8#1

@danhermann
Copy link
Contributor Author

I think there was a problem with the workaround, so these tests will probably fail if unmuted. The Java security manager blocks reading /proc/meminfo - see for example https://gradle-enterprise.elastic.co/s/6qtcnglfzfdvg/tests/:server:test/org.elasticsearch.monitor.os.OsProbeTests/testGetTotalMemoryOnDebian8#1

Ah, thanks for pointing that out, @droberts195.

@danhermann
Copy link
Contributor Author

@droberts195, I opened #68742 to address the security manager issue.

@danhermann
Copy link
Contributor Author

#68742 has been merged and the previously failing test on the debian8 platform passed, so I think this PR is clear to be reviewed.

Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit

package org.elasticsearch.monitor.os;

import static org.hamcrest.Matchers.allOf;
import static org.hamcrest.Matchers.anyOf;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These import changes are not needed for this change, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit that muted these tests (09f823b) moved the import statements out of the standard ordering that we use, so I just restored the original standard ordering as part of the un-mute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>test Issues or PRs that are addressing/adding tests v7.11.2 v7.12.1 v7.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants