Use Custom Class instead of Tuple for Cached Byte Positions #68662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `Tuple` all over is somewhat read to read and forces us to duplicate a lot of assertions. Using a custom class dries up the assertions and makes the code easier to follow by adding utilities for some common region math spots.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 8, 2021
…68662) Using `Tuple` all over is somewhat read to read and forces us to duplicate a lot of assertions. Using a custom class dries up the assertions and makes the code easier to follow by adding utilities for some common region math spots.
original-brownbear
added a commit
that referenced
this pull request
Feb 8, 2021
…68709) Using `Tuple` all over is somewhat read to read and forces us to duplicate a lot of assertions. Using a custom class dries up the assertions and makes the code easier to follow by adding utilities for some common region math spots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a suggestion, but IMO this is much simpler and makes enables some drier solutions for the cache file math down the line:
Using
Tupleall over is somewhat read to read and forces us to duplicatea lot of assertions. Using a custom class dries up the assertions and makes
the code easier to follow by adding utilities for some common region math spots.