build-tools check are fixed on aarch64 #68630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
breskeby
changed the title
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
force-pushed
the
ignore-BwcVersionsTest-on-aarch
branch
from
050ab49 to
4c70698
Compare
breskeby
changed the title
breskeby
commented
Feb 9, 2021
|
|
||
| @BeforeClass | ||
| public static void setupAll() { | ||
| Assume.assumeFalse(Architecture.current() == Architecture.AARCH64); |
Contributor
Author
There was a problem hiding this comment.
For now we just ignore the unit tests on aarch64 as we filter out there anything < 7.12
breskeby
requested review from
mark-vieira and
pugnascotia
and removed request for
pugnascotia
pugnascotia
approved these changes
Feb 9, 2021
simplifies architecture references in url etc.
breskeby
force-pushed
the
ignore-BwcVersionsTest-on-aarch
branch
from
a0ecd3c to
a042870
Compare
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 15, 2021
* Igmore BwcVersionsTests on aarch64 * Introduce classifier field to Architecture * Add test coverage for downloading adoptjdk aarch64 jdks
breskeby
added a commit
that referenced
this pull request
Feb 16, 2021
* build-tools check are fixed on aarch64 (#68630) * Ignore BwcVersionsTests on aarch64 * Introduce classifier field to Architecture * Add test coverage for downloading adoptjdk aarch64 jdks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some coverage for our build tools dealing with
aarch64.