Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Feb 4, 2021

Adds docs for the filter_path parameter to the EQL docs.

While the filter_path parameter is already covered in our API conventions docs, response filtering is particularly useful for EQL users. Those users may not be aware of the parameter otherwise.

Previews

@jrodewig jrodewig marked this pull request as ready for review February 4, 2021 17:40
@elasticmachine elasticmachine added Team:QL (Deprecated) Meta label for query languages team Team:Docs Meta label for docs team labels Feb 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left one comment/suggestion though.

// TEST[setup:sec_logs]

Use the <<common-options-response-filtering,`filter_path`>> query parameter to
filter the properties returned in the API response. For example, the following
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't call those elements "properties". I think it's more like components or elements. Or maybe leave out a name for them and just state that it's "filtering the response content".

Copy link
Contributor Author

@jrodewig jrodewig Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @astefan! I've reworded to avoid "properties."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/EQL EQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.10.3 v7.11.1 v7.12.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants