GeoIP database downloader #68424
Merged
GeoIP database downloader #68424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds component that will download new GeoIP databases from infra service
martijnvg
reviewed
Feb 3, 2021
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
I left a few more comments.
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Outdated
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Outdated
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/IngestGeoIpPlugin.java
Outdated
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/HttpClient.java
Outdated
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Outdated
Show resolved
Hide resolved
martijnvg
reviewed
Feb 4, 2021
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Outdated
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/compress/CompressorFactory.java
Outdated
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Outdated
Show resolved
Hide resolved
martijnvg
reviewed
Feb 4, 2021
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Outdated
Show resolved
Hide resolved
martijnvg
reviewed
Feb 10, 2021
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
martijnvg
approved these changes
Feb 18, 2021
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
I left a few minor comments. Other than that, LGTM 🎉
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/IngestGeoIpPlugin.java
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
Show resolved
Hide resolved
...s/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloaderTaskExecutor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2021
This change adds component that will download new GeoIP databases from infra service New databases are downloaded in chunks and stored in .geoip_databases index Downloads are verified against MD5 checksum provided by the server Current state of all stored databases is stored in cluster state in persistent task state Relates to elastic#68920 # Conflicts: # modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/IngestGeoIpPlugin.java
probakowski
added a commit
that referenced
this pull request
Feb 24, 2021
This change adds component that will download new GeoIP databases from infra service New databases are downloaded in chunks and stored in .geoip_databases index Downloads are verified against MD5 checksum provided by the server Current state of all stored databases is stored in cluster state in persistent task state Relates to #68920
probakowski
added a commit
that referenced
this pull request
Feb 24, 2021
This change adjust versions in GeoIpTaskParams and GeoIpTaskState after backporting #68424 to 7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds component that will download new GeoIP databases from infra service
New databases are downloaded in chunks and stored in
.geoip_databasesindexDownloads are verified against MD5 checksum provided by the server
Current state of all stored databases is stored in cluster state in persistent task state
Relates to #68920