Fix testDeleteActionDoesntDeleteSearchableSnapshot #68376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidan
added
>test
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Feb 2, 2021
(cherry picked from commit 4ce4a12) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Feb 2, 2021
(cherry picked from commit 4ce4a12) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Feb 3, 2021
(cherry picked from commit 4ce4a12) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Feb 3, 2021
(cherry picked from commit 4ce4a12) Signed-off-by: Andrei Dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flakiness was caused by the assertions in the test not capturing
the expected ILM state. Namely, asserting the
restoredindex doesn'texist is also true before it ever exists (not only after it's deleted)
The intention was to assert ILM finished execution for the restored and
the index was deleted.
This changes the code to assert both the original managed and the restored
index do not exist before moving on to assert the snapshot survives the
deleteaction execution.Fixes #67712