Add grant-api-key to HLRC #68190
Merged
Add grant-api-key to HLRC #68190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for "Grant API Key" to the Java High Level Rest Client. This API was added in Elasticsearch 7.7 but did not have explicit support in the HLRC.
tvernum
added
>enhancement
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Contributor
Author
lcawl
approved these changes
Jan 29, 2021
Contributor
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
Yes, thanks! That will give us the necessary inclusions for the docs
jkakavas
approved these changes
Feb 1, 2021
Contributor
jkakavas
left a comment
jkakavas
left a comment
There was a problem hiding this comment.
LGTM, minus that small test fix
| RestHighLevelClient client = highLevelClient(); | ||
|
|
||
| final String username = "grant_apikey_user"; | ||
| final String passwordString = randomAlphaOfLengthBetween(14, 18); |
Contributor
There was a problem hiding this comment.
FIPS 140 stamp of approval.
...t/rest-high-level/src/test/java/org/elasticsearch/client/SecurityRequestConvertersTests.java
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine update branch |
1 similar comment
Contributor
Author
|
@elasticmachine update branch |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Feb 9, 2021
This adds support for "Grant API Key" to the Java High Level Rest Client. This API was added in Elasticsearch 7.7 but did not have explicit support in the HLRC. Backport of: elastic#68190
tvernum
added a commit
that referenced
this pull request
Feb 10, 2021
This adds support for "Grant API Key" to the Java High Level Rest Client. This API was added in Elasticsearch 7.7 but did not have explicit support in the HLRC. Backport of: #68190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for "Grant API Key" to the Java High Level Rest
Client.
This API was added in Elasticsearch 7.7 but did not have explicit support
in the HLRC.