Add ClusterUUID to RepositoryData #68002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Record the clusterUUID of the last cluster to write to a repository in the `RepositoryData` and use it for more meaningful logging when running into a concurrent modification issue.
original-brownbear
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Jan 27, 2021
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Looks good, left just a few nits
test/framework/src/main/java/org/elasticsearch/snapshots/AbstractSnapshotIntegTestCase.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
...y-multi-version/src/test/java/org/elasticsearch/upgrades/MultiVersionRepositoryAccessIT.java
Outdated
Show resolved
Hide resolved
...y-multi-version/src/test/java/org/elasticsearch/upgrades/MultiVersionRepositoryAccessIT.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Jenkins run elasticsearch-ci/oss-distro-docs (unrelated + known) |
Contributor
Author
|
Thanks David, all points addressed I think :) |
Contributor
Author
|
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 15, 2021
Record the clusterUUID of the last cluster to write to a repository in the `RepositoryData` and use it for more meaningful logging when running into a concurrent modification issue.
original-brownbear
added a commit
that referenced
this pull request
Feb 15, 2021
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo uuid change gives us an in to get this long requested change in for free in terms of BwC worries =>
Record the clusterUUID of the last cluster to write
to a repository in the
RepositoryDataand use it for moremeaningful logging when running into a concurrent modification
issues.