Allow deletion of async searches with the manage privilege #67965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users that do not initiated an async search to delete it if they have the cluster manage and manage-security privilege. It is equivalent to the cancellation of tasks through the task manager (same privilege required) and will allow users with the right permissions to cancel/delete async searches if they know the async execution id.
jimczi
added
>enhancement
:Search/Search
Contributor
|
@elasticmachine update branch |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
albertzaharovits
approved these changes
Feb 5, 2021
Contributor
albertzaharovits
left a comment
albertzaharovits
left a comment
There was a problem hiding this comment.
LGTM
We discussed that we (Security) must investigate how to do authorization around requests that contain handlers that have ownership, so that we don't pollute the async tasks logic with authorization checks.
I will raise an issue.
.../qa/security/src/javaRestTest/java/org/elasticsearch/xpack/search/AsyncSearchSecurityIT.java
Outdated
Show resolved
Hide resolved
jimczi
added a commit
that referenced
this pull request
Feb 8, 2021
This change allows users that do not initiated an async search to delete it if they have the cluster manage and manage-security privilege. It is equivalent to the cancellation of tasks through the task manager (same privilege required) and will allow users with the right permissions to cancel/delete async searches if they know the async execution id.
|
@jimczi do we need anything else to grant this permission to the kibana user? Or does it already have it? |
Contributor
Author
|
@lizozom , not yet. This PR allows any user with the manage privilege to delete async searches. I'll open a follow up to determine how the kibana_system could have this privilege by default. |
|
Please share the PR with me for tracking 🙏 |
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Feb 8, 2021
This change adds a new cluster privilege that allows to: * Cancel running tasks (_tasks/_cancel). * Cancel and delete async searches. Today the 'manage' cluster privilege is required to cancel tasks and to delete async searches when security features are enabled. This new focused privilege allows to handle tasks and searches only. The change also adds the privilege to the internal 'kibana_system' and '_async_search' roles. They both need to be able to cancel tasks and delete async searches. Relates elastic#67965
Contributor
Author
jimczi
added a commit
that referenced
this pull request
Feb 16, 2021
…8679) This change adds a new cluster privilege cancel_task that allows to: Cancel running tasks (_tasks/_cancel). Cancel and delete async searches. Today the 'manage' cluster privilege is required to cancel tasks and to delete async searches when security features are enabled. This new focused privilege allows to handle tasks and searches only. The change also adds the privilege to the internal 'kibana_system' and '_async_search' roles. They both need to be able to cancel tasks and delete async searches. Relates #67965
jimczi
added a commit
that referenced
this pull request
Feb 16, 2021
…8679) (#69023) This change adds a new cluster privilege cancel_task that allows to: Cancel running tasks (_tasks/_cancel). Cancel and delete async searches. Today the 'manage' cluster privilege is required to cancel tasks and to delete async searches when security features are enabled. This new focused privilege allows to handle tasks and searches only. The change also adds the privilege to the internal 'kibana_system' and '_async_search' roles. They both need to be able to cancel tasks and delete async searches. Relates #67965
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users that do not initiated an async search to delete it
if they have the cluster manage and manage-security privileges.
It is equivalent to the cancellation of tasks through the task manager (same privilege required)
and will allow users with the right permissions to cancel/delete async searches if they know
the async execution id.