[ML] Persist data counts in DFA final step with ML origin #67674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#67623 I moved persisting the data counts at the end of a data frame analytics job into a `FinalStep` class. However, I forgot to execute the index request with ML origin resulting in authentication problems if the user that runs the DFA job does not have read privileges in the ML stats index. This commit fixes this by executing that index request with ML origin.
Collaborator
|
Pinging @elastic/ml-core (:ml) |
dimitris-athanasiou
deleted the
persist-data-counts-in-dfa-final-step-with-ml-origin
branch
dimitris-athanasiou
added a commit
that referenced
this pull request
Jan 19, 2021
… (#67683) In #67623 I moved persisting the data counts at the end of a data frame analytics job into a `FinalStep` class. However, I forgot to execute the index request with ML origin resulting in authentication problems if the user that runs the DFA job does not have read privileges in the ML stats index. This commit fixes this by executing that index request with ML origin. Backport of #67674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #67623 I moved persisting the data counts at the end of a
data frame analytics job into a
FinalStepclass. However,I forgot to execute the index request with ML origin resulting
in authentication problems if the user that runs the DFA job
does not have read privileges in the ML stats index.
This commit fixes this by executing that index request with ML
origin.