Skip to content

Conversation

@henningandersen
Copy link
Contributor

@henningandersen henningandersen commented Jan 8, 2021

We no longer regard the autoscaling APIs experimental though they are
only intended for use by ESS/ECE/ECK. This commit updates the docs
to reflect this and adds a minimal set of documentation for the
feature.

@henningandersen henningandersen added the >docs General docs changes label Jan 8, 2021
We no longer regard the autoscaling APIs experimental though they are
only intended for use by ESS/ECE/ECK. This commit updates the docs
to reflect this and adds a minimal set of documentation for the
feature.
@henningandersen henningandersen force-pushed the docs_autoscaling_not_experimental branch from d1d5761 to 3fbf3b2 Compare January 11, 2021 09:01
@henningandersen henningandersen marked this pull request as ready for review January 11, 2021 09:02
@elasticmachine elasticmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team labels Jan 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

henningandersen added a commit to henningandersen/elasticsearch that referenced this pull request Jan 11, 2021
Autoscaling APIs are no longer considered experimental and no longer
hidden behind a feature flags. Updated the API specification
accordingly.

Relates elastic#67202 and elastic#65973
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. I left several suggestions, but feel free to ignore those if wanted.

Two larger pieces of non-blocking feedback:

  • I'd add a sentence or two about what deciders are and how autoscaling uses them to the top-level page. There isn't a conceptual intro to deciders in the docs currently.
  • I'd create a separate Parameters or Options section for configuration options in each decider reference page.

Comment on lines 10 to 15
single configuration option `forecast_window` is available, defaulting to 30
minutes.

The estimation of expected additional data is based on past indexing that
occurred within the `forecast_window`, i.e., by default the last 30 minutes.
Only indexing into data streams contributes to the estimate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd typically put this in a Parameters or Options section with a def for forecast_window.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this in d0429bd

@henningandersen
Copy link
Contributor Author

Thanks so much for the many suggestions, @jrodewig. I believe I addressed all of them. I added a Configuration settings section to the decider pages in d0429bd.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few formatting nits, but this looks great to me. Thanks @henningandersen!

henningandersen added a commit that referenced this pull request Jan 12, 2021
Autoscaling APIs are no longer considered experimental and no longer
hidden behind a feature flags. Updated the API specification
accordingly.

Relates #67202 and #65973
henningandersen added a commit that referenced this pull request Jan 12, 2021
Autoscaling APIs are no longer considered experimental and no longer
hidden behind a feature flags. Updated the API specification
accordingly.

Relates #67202 and #65973
henningandersen added a commit that referenced this pull request Jan 12, 2021
Autoscaling APIs are no longer considered experimental and no longer
hidden behind a feature flags. Updated the API specification
accordingly.

Relates #67202 and #65973
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henningandersen henningandersen merged commit cc30ae8 into elastic:master Jan 12, 2021
henningandersen added a commit that referenced this pull request Jan 13, 2021
We no longer regard the autoscaling APIs experimental though they are
only intended for use by ESS/ECE/ECK. This commit updates the docs
to reflect this and adds a minimal set of documentation for the
feature.

Co-authored-by: James Rodewig <[email protected]>
henningandersen added a commit that referenced this pull request Jan 13, 2021
We no longer regard the autoscaling APIs experimental though they are
only intended for use by ESS/ECE/ECK. This commit updates the docs
to reflect this and adds a minimal set of documentation for the
feature.

Co-authored-by: James Rodewig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Autoscaling >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.11.1 v7.12.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants