Remove ban parent-task BWC #66525
Merged
Remove ban parent-task BWC #66525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>non-issue
:Distributed Coordination/Task Management
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
requested changes
Dec 17, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I think we can fix the test rather than simply removing it :)
| if (event.nodesRemoved()) { | ||
| synchronized (bannedParents) { | ||
| lastDiscoveryNodes = event.state().getNodes(); | ||
| // Remove all bans that were registered by nodes that are no longer in the cluster state |
| } | ||
|
|
||
| @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/66518") | ||
| public void testTaskCancellationOnCoordinatingNodeLeavingTheCluster() throws Exception { |
Contributor
There was a problem hiding this comment.
Hmm this test seems somewhat useful, although I see that it's not quite valid any more. Can we make it valid again by, say, closing the connections from the "removed" nodes?
Contributor
There was a problem hiding this comment.
The adjusted test fails for me after a few iterations. Not reproducibly, otherwise I'd share a seed, but hopefully you can see this too.
Member
Author
There was a problem hiding this comment.
Thanks for checking. I will run it a few hundred iterations.
Member
Author
|
@DaveCTurner Would you please take another look? Thank you. |
Member
Author
|
Thanks David. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This BWC is no longer needed after backporting #66066 to 7.x.
Closes #66518