[Backport] Add resilience in TokenAuthIntegTests #66314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testExpiredTokensDeletedAfterExpiration method assumed that invalidating a refresh token immediately after the delete task was run would behave as if the token did not exist. However, the Elasticsearch concurrency controls do not guarantee that behaviour. It is possible for the request that searches for the token document the corresponds to the refresh token to find an invalidated but not yet deleted document which is reflected in the API response. This change makes the test resilient to this behaviour by wrapping the assertion in an assertBusy Backport of: elastic#64757
Contributor
|
No that doesn't make sense, I thought I was looking at a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testExpiredTokensDeletedAfterExpiration method assumed that
invalidating a refresh token immediately after the delete task was run
would behave as if the token did not exist.
However, the Elasticsearch concurrency controls do not guarantee that
behaviour. It is possible for the request that searches for the token
document the corresponds to the refresh token to find an invalidated
but not yet deleted document which is reflected in the API response.
This change makes the test resilient to this behaviour by wrapping the
assertion in an assertBusy
Backport of: #64757