Accept more ingest simulate params as ints or strings #66197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvernum
added
the
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Contributor
|
@elasticmachine test this please |
Contributor
|
@elasticmachine ok to test |
Contributor
|
@elasticmachine update branch |
probakowski
approved these changes
Jan 11, 2021
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
LGTM, thank you @gaobinlong for fixing this!
I'll get this merged and backported.
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Jan 11, 2021
_version, _if_seq_no and _if_primary_term params in the simulate pipeline API cannot be parsed correctly when the value is integer orstring type. This PR fix the bug and modify the test method to test it. # Conflicts: # server/src/test/java/org/elasticsearch/action/ingest/SimulatePipelineRequestParsingTests.java
Contributor
|
I found a problem during backport |
probakowski
added a commit
that referenced
this pull request
Feb 19, 2021
After #66197 we've lost ability to use longs for version, if_seq_no and if_primary_term (only ints would work). That slipped through because 1 test went missing after refactoring in #50131. This change fixes that with new ConfigurationUtils.readOptionalStringOrLongProperty method and and brings back the test.
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 19, 2021
probakowski
added a commit
that referenced
this pull request
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #65992.
Seem to #23823.
_version,_if_seq_noand_if_primary_termparams in thesimulate pipelineAPI cannot be parsed correctly when the value isintegerorstringtype.This PR fix the bug and modify the test method to test it.