Remove the rollup thread pool #65958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the rollup action in order to execute on a per shard basis. Each shard is responsible for sending its local buckets to the target rollup index. The shard action is executed in the rollup thread pool in order to limit the number of shards that can rollup concurrently per node. Buckets are computed on the fly using the index searcher and they are sorted using a compressed offline sorter. This commit also removes the rollup thread pool usage in the RollupAsyncIndexer that is used by the legacy rollup and transforms. All actions performed by this indexer are asynchronous so using the generic thread pool to fire search and bulk requests is ok.
This commit removes the rollup thread pool and replaces all its usage with the generic one. The rollup indexer uses the internal client to perform asynchronous search and indexation tasks so we don't need a separate pool to handle these requests.
jimczi
added
>enhancement
:StorageEngine/Rollup
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
talevy
reviewed
Dec 7, 2020
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
Overall looks great!
we're positive that this is OK with Transforms as well?
x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/FieldValueFetcher.java
Outdated
Show resolved
Hide resolved
...m/src/test/java/org/elasticsearch/xpack/transform/transforms/TransformIndexerStateTests.java
Outdated
Show resolved
Hide resolved
hendrikmuhs
reviewed
Dec 7, 2020
...m/src/test/java/org/elasticsearch/xpack/transform/transforms/TransformIndexerStateTests.java
Outdated
Show resolved
Hide resolved
jimczi
added a commit
that referenced
this pull request
Dec 18, 2020
This commit removes the rollup thread pool usage in the RollupAsyncIndexer that is used by the legacy rollup and transforms. All actions performed by this indexer are asynchronous so using the generic thread pool to fire search and bulk requests is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the rollup thread pool and replaces all its usage
with the generic one. The rollup indexer uses the internal client to
perform asynchronous search and indexation tasks so we don't need a
separate pool to handle these requests.