Remove usage of .watches system index in full cluster restart. #65884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use for the cluster state api to check the index.format setting of the .watches index instead of querying the index settings api. This removes the last direct usage of .watches index mentioned in elastic#62501.
martijnvg
added
>test
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
38 tasks
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
jakelandis
reviewed
Dec 4, 2020
| } | ||
| } | ||
| // Verify .watches index format: | ||
| var getClusterStateResponse = entityAsMap(client().performRequest(new Request("GET", "/_cluster/state"))); |
Contributor
There was a problem hiding this comment.
nit: GET /_cluster/state/metadata/.watches would be tiny bit more efficient.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Dec 7, 2020
Backport elastic#65884 to 7.x branch. Make use for the cluster state api to check the index.format setting of the .watches index instead of querying the index settings api. This removes the last direct usage of .watches index mentioned in elastic#62501.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use for the cluster state api to check the index.format setting
of the .watches index instead of querying the index settings api.
This removes the last direct usage of .watches index mentioned in #62501.