[DOCS] Correct the default value of wait_for_completion query param
#65800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Contributor
|
Thanks for raising this @gaobinlong. However, I believe the To simplify things, I pushed 21c22bd to update docs containing the parameter and get rid of the reuse. @debadair Do you mind double-checking my work here? If everything looks good, I'll merge this in. |
Contributor
|
@elasticmachine test this please |
jrodewig
added
the
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
jrodewig
changed the title
wait_for_completion query param
debadair
approved these changes
Dec 4, 2020
Contributor
debadair
left a comment
debadair
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking care of this! Reuse is great...except when it isn't.
This was referenced Dec 4, 2020
jrodewig
added a commit
that referenced
this pull request
Dec 4, 2020
…#65800) (#65902) Co-authored-by: James Rodewig <[email protected]> Co-authored-by: bellengao <[email protected]>
jrodewig
added a commit
that referenced
this pull request
Dec 4, 2020
…#65800) (#65903) Co-authored-by: James Rodewig <[email protected]> Co-authored-by: bellengao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter
wait_for_completion's default value should befalse, but istruenow.