Skip to content

Fix ingest java week based year defaulting #65717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2020
Merged

Fix ingest java week based year defaulting #65717

merged 1 commit into from
Dec 28, 2020

Conversation

@pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Dec 2, 2020

If year, year of era, or weekbased year is not specified ingest Java
date processor is defaulting year to current year.
However the current implementation has mistaken weekBasedYear field with
weekOfWeekBasedYear. This has lead to incorrect defaulting.

relates #63458

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
Fix ingest java week based year defaulting
ba5dbdb 
If year, year of era, or weekbased year is not specified ingest Java
date processor is defaulting year to current year.
However the current implementation has mistaken weekBasedYear field with
weekOfWeekBasedYear. This has lead to incorrect defaulting.

relates elastic#63458
@pgomulka pgomulka added :Core/Infra/Core Core issues without another label :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.11.0 labels Dec 2, 2020
@pgomulka pgomulka self-assigned this Dec 2, 2020
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Core/Infra Meta label for core/infra team labels Dec 2, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 2, 2020

Pinging @elastic/es-core-features (Team:Core/Features)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 2, 2020

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka requested a review from rjernst December 2, 2020 08:27
@pgomulka pgomulka mentioned this pull request Dec 2, 2020
Merged
@pgomulka
Copy link
Contributor Author

pgomulka commented Dec 2, 2020

@elasticmachine run elasticsearch-ci/2

rjernst
rjernst approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 8f74f18 into elastic:master Dec 28, 2020
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Dec 28, 2020
@pgomulka
Fix ingest java week based year defaulting backport(elastic#65717)
6c78bfc 
If year, year of era, or weekbased year is not specified ingest Java
date processor is defaulting year to current year.
However the current implementation has mistaken weekBasedYear field with
weekOfWeekBasedYear. This has lead to incorrect defaulting.

relates elastic#63458
pgomulka added a commit that referenced this pull request Dec 28, 2020
@pgomulka
Fix ingest java week based year defaulting backport(#65717) (#66829)
6b67f58 
If year, year of era, or weekbased year is not specified ingest Java
date processor is defaulting year to current year.
However the current implementation has mistaken weekBasedYear field with
weekOfWeekBasedYear. This has lead to incorrect defaulting.

relates #63458
@pgomulka pgomulka mentioned this pull request May 11, 2021
Merged
pgomulka added a commit that referenced this pull request May 11, 2021
@pgomulka
[doc] Add Release notes for date defaulting in ingest (#72927)
56f92d5 
the bug fixed in 7.12 changed the way the year is defaulted
the bug fix - #65717
the bug was introduced by #58597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst approved these changes

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team v7.11.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgomulka @elasticmachine @rjernst @jakelandis