Return partial failures if search was cancelled. #65467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#63520, we started cancelling searches that encounter shard failures and don't allow partial results. In this case we return an 'all shards failed' response, since there are no successful responses. This PR proposes to return a 'partial shards failure' instead. The reasoning: it's misleading to claim that 'all shards failed' when we only know at least one shard failed (and preemptively cancelled the rest).
jtibshirani
added
>bug
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64382.