[ML] Adjust assertion in Grok pattern creation code #65421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that there _is_ a situation where the regex for a category definition will not match all the examples: where one or more examples have been truncated. Previously we had an assertion that this would never happen. This only affected development, as in production assertions are disabled. However, it makes sense to adjust the assertion and comment to reflect reality.
Collaborator
|
Pinging @elastic/ml-core (:ml) |
droberts195
pushed a commit
that referenced
this pull request
Nov 24, 2020
It turns out that there _is_ a situation where the regex for a category definition will not match all the examples: where one or more examples have been truncated. Previously we had an assertion that this would never happen. This only affected development, as in production assertions are disabled. However, it makes sense to adjust the assertion and comment to reflect reality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that there is a situation where the
regex for a category definition will not match all
the examples: where one or more examples have been
truncated.
Previously we had an assertion that this would never
happen. This only affected development, as in
production assertions are disabled. However, it
makes sense to adjust the assertion and comment to
reflect reality.