Adds realm name OIDC _security/oidc/prepare and _security/oidc/authenticate APIs responses
#64966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161
Contributor
Author
|
@elasticmachine update branch |
ywangd
added
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security (:Security/Authentication) |
ywangd
reviewed
Nov 12, 2020
Member
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
I have two questions:
- We recently added the
authenticationfield toOpenIdConnectAuthenticateResponse. This new field already has realm information and more. Do we still need to add another field which repeats the same info fromauthenticaton? - We haven't really been very consistent on how realm is rendered in requests and responses. Also metadata and audit log could have different format as well. So I wonder whether
realm_nameis really what we want to name this field. Other options could be:realm- this is what is used in the prepare auth request- or an object of
{"realm": {"name":"", "type":""}}- this is what is used forauthenticationand a few other places
...-op-tests/src/test/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthIT.java
Outdated
Show resolved
Hide resolved
...ava/org/elasticsearch/xpack/core/security/action/oidc/OpenIdConnectAuthenticateResponse.java
Outdated
Show resolved
Hide resolved
Contributor
Author
This is really a good point! Will remove it from OpenIdConnectAuthenticateResponse |
Contributor
Author
I see we are not super consistant here. Using "realm_name" in api key APIs and "realm" for saml some saml APIs, and then there is {"realm": {"name":"", "type":""}}... |
…on to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161
…on to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161
ywangd
approved these changes
Nov 16, 2020
...-op-tests/src/test/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthIT.java
Outdated
Show resolved
Hide resolved
...-op-tests/src/test/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthIT.java
Outdated
Show resolved
Hide resolved
…on to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161
BigPandaToo
added a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 17, 2020
…henticate` APIs responses (elastic#64966) * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161 Co-authored-by: Elastic Machine <[email protected]>
BigPandaToo
added a commit
that referenced
this pull request
Nov 18, 2020
…henticate` APIs responses (#64966) (#65164) * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves #53161 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves #53161 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves #53161 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves #53161 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161