Fix incorrect setContextClassLoader permissions #64745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netty requires the setContextClassLoader permission. However, many of our policy files incorrectly use `*` as the name, thinking `setContextClassLoader` is the actions element of the permission (it looks like a copy paste error that was then itself copy pasted through several policy files). This commit corrects these permissions, which had actually granted all RuntimePermissions.
rjernst
added
>non-issue
:Security/Security
Collaborator
|
Pinging @elastic/es-security (:Security/Security) |
Member
Author
|
@elasticmachine run elasticsearch-ci/1 |
rjernst
added a commit
that referenced
this pull request
Nov 7, 2020
Netty requires the setContextClassLoader permission. However, many of our policy files incorrectly use `*` as the name, thinking `setContextClassLoader` is the actions element of the permission (it looks like a copy paste error that was then itself copy pasted through several policy files). This commit corrects these permissions, which had actually granted all RuntimePermissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netty requires the setContextClassLoader permission. However, many of
our policy files incorrectly use
*as the name, thinkingsetContextClassLoaderis the actions element of the permission (itlooks like a copy paste error that was then itself copy pasted through
several policy files). This commit corrects these permissions, which had
actually granted all RuntimePermissions.