Don't invalidate refresh token a second time #64259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the token service so that it recognises when a refresh token is already invalidated and does not attempt to invalidated it again. Although the update would be detected as a no-op and handled appropriately, the code could fail if the underlying document was deleted between the search and the update. Since we know that update will be a no-op, we can skip any attempt to do the update, and return immediately. Relates: elastic#56903
tvernum
added
>bug
:Security/Authentication
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Nov 6, 2020
This changes the token service so that it recognises when a refresh token is already invalidated and does not attempt to invalidated it again. Although the update would be detected as a no-op and handled appropriately, the code could fail if the underlying document was deleted between the search and the update. Since we know that update will be a no-op, we can skip any attempt to do the update, and return immediately. Backport of: elastic#64259
tvernum
added a commit
that referenced
this pull request
Nov 9, 2020
This changes the token service so that it recognises when a refresh token is already invalidated and does not attempt to invalidated it again. Although the update would be detected as a no-op and handled appropriately, the code could fail if the underlying document was deleted between the search and the update. Since we know that update will be a no-op, we can skip any attempt to do the update, and return immediately. Backport of: #64259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the token service so that it recognizes when a refresh
token is already invalidated and does not attempt to invalidated it
again.
Although the update would be detected as a no-op and handled
appropriately, the code could fail if the underlying document was
deleted between the search and the update.
Since we know that update will be a no-op, we can skip any attempt to
do the update, and return immediately.
Relates: #56903