Use watcher get api instead of .watches index. #64199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces querying .watches index with using the watcher get api where possible. These cases queried a specific watch by id and then checked if the count is 1 and some properties of the actual watch. This can be replaced by just using the get watch api. Relates to elastic#62501
martijnvg
added
>test
martijnvg
commented
Oct 27, 2020
|
|
||
| - match: { status.state.active : false } | ||
|
|
||
| - do: |
Member
Author
There was a problem hiding this comment.
These test already made the corresponding get watch api calls,
so only need to remove the search api calls here.
38 tasks
jakelandis
approved these changes
Oct 27, 2020
Contributor
jakelandis
left a comment
jakelandis
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 28, 2020
Replaces querying .watches index with using the watcher get api where possible. These cases queried a specific watch by id and then checked if the count is 1 and some properties of the actual watch. This can be replaced by just using the get watch api. Relates to elastic#62501
martijnvg
added a commit
that referenced
this pull request
Oct 28, 2020
Backport of #64199 to 7.x branch. Replaces querying .watches index with using the watcher get api where possible. These cases queried a specific watch by id and then checked if the count is 1 and some properties of the actual watch. This can be replaced by just using the get watch api. Relates to #62501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces querying .watches index with using the watcher get api where possible.
These cases queried a specific watch by id and then checked if the count is 1 and
some properties of the actual watch. This can be replaced by just using the get
watch api.
Relates to #62501