Return the same point in time in search response #64188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>non-issue
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
jimczi
approved these changes
Oct 27, 2020
server/src/main/java/org/elasticsearch/action/search/AbstractSearchAsyncAction.java
Show resolved
Hide resolved
Member
Author
|
run elasticsearch-ci/packaging-sample-unix |
dnhatn
added a commit
that referenced
this pull request
Oct 27, 2020
With this change, we will always return the same point in time in a search response as its input until we implement the retry mechanism for the point in times.
dnhatn
added a commit
that referenced
this pull request
Oct 27, 2020
With this change, we will always return the same point in time in a search response as its input until we implement the retry mechanism for the point in times.
jtibshirani
reviewed
Apr 28, 2021
| boolean includeSearchContextInResponse() { | ||
| return request.pointInTimeBuilder() != null; | ||
| boolean buildPointInTimeFromSearchResults() { | ||
| // TODO: Until we implement the retry mechanism for point in times (i.e., replace an unavailable shard with an equivalent copy), |
Contributor
There was a problem hiding this comment.
I noticed this TODO while working on an unrelated refactor. Do we need to address the TODO now that we retry point-in-times (#66713)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we will always return the same point in time in a search response as its input until we implement the retry mechanism for the point in times.