Expose the list of completed ranges in SparseFileTracker #64145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
Contributor
|
@tlrx I'll take a look here shortly. Just FYI the test failure here is reproducible in master as well. I'm looking into it |
Contributor
|
Test failure is fixed by #64150 |
original-brownbear
approved these changes
Oct 26, 2020
| if (range.isPending()) { | ||
| continue; | ||
| } | ||
| if (completedRanges == null) { |
Contributor
There was a problem hiding this comment.
Random NIT/Question: why use a LinkedList for this, seems if we're actually worried about this running so often that it'll be tricky on the GC ArrayList would perform more predictably and is what we generally use for this type of spot?
Member
Author
There was a problem hiding this comment.
Agreed, that's what we usually use, I changed that.
Member
Author
|
Thanks Armin |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Oct 26, 2020
This commit adds a new method getCompletedRanges() to the SparseFileTracker class. This will be useful for the persistent cache that will need to retrieve the list of completed ranges before fsyncing a cache file.
tlrx
added a commit
that referenced
this pull request
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
getCompletedRanges()to theSparseFileTrackerclass. This will be useful for the persistent cache that will need to retrieve the list of completed ranges before fsyncing a cache file.