Make agg test less confusing #63952
Merged
Make agg test less confusing #63952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>test
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
We have an `@After` annotated method in `AggregatorTestCase` that cleans up releasibles. But it was `private`! Confusingly, it seemed to be working! I'm not sure why. This makes it public which is a little more sensible.
Member
Author
|
I'm not really sure how this worked before. But this makes a little more sense. |
javanna
approved these changes
Oct 20, 2020
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
making it public certainly makes sense! that it worked when it was private, that I really don't understand.
Contributor
|
|
Member
Author
It was working, yeah. @javanna found it and sent it my way. Is weird. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 20, 2020
We have an `@After` annotated method in `AggregatorTestCase` that cleans up releasibles. But it was `private`! Confusingly, it seemed to be working! I'm not sure why. This makes it public which is a little more sensible.
nik9000
added a commit
that referenced
this pull request
Oct 20, 2020
pugnascotia
pushed a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Oct 21, 2020
We have an `@After` annotated method in `AggregatorTestCase` that cleans up releasibles. But it was `private`! Confusingly, it seemed to be working! I'm not sure why. This makes it public which is a little more sensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an
@Afterannotated method inAggregatorTestCasethat cleansup releasibles. But it was
private! Confusingly, it seemed to beworking! I'm not sure why. This makes it public which is a little more
sensible.