Add REST Test for Snapshot Clone API #63863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was still missing, we should at least have one test that verifies that the REST API actually works.
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
tlrx
approved these changes
Oct 19, 2020
Contributor
Author
|
|
||
| @Override | ||
| public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException { | ||
| builder.startObject(); |
Contributor
Author
There was a problem hiding this comment.
This is kind of meh, we technically only need the indices and indices options fields here for the HLRC client. But then I dug into it and found that we add all these redundant fields for other requests as well so I kept it consistent here for now. I have an idea on how to make this nicer that I'd put in a follow up (could just use a params entry here).
tlrx
approved these changes
Oct 19, 2020
Contributor
Author
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 19, 2020
Adds snapshot clone REST tests and HLRC support for the API.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 19, 2020
Adds snapshot clone REST tests and HLRC support for the API.
original-brownbear
added a commit
that referenced
this pull request
Oct 20, 2020
original-brownbear
added a commit
that referenced
this pull request
Oct 20, 2020
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 23, 2021
tlrx
added a commit
that referenced
this pull request
Mar 24, 2021
This commit adds some missing documentation about the Clone Snapshot Java API. Relates #63863
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 24, 2021
This commit adds some missing documentation about the Clone Snapshot Java API. Relates elastic#63863
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 24, 2021
This commit adds some missing documentation about the Clone Snapshot Java API. Relates elastic#63863
tlrx
added a commit
that referenced
this pull request
Mar 24, 2021
tlrx
added a commit
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was still missing, we should at least have one test that verifies
that the REST API actually works.