Make stack.templates.enabled a dynamic setting #63764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the setting for disabling the automatically installed stack templates (the `logs-*-*`, `metrics-*-*`, and `synthetics-*-*` templates) to be changed dynamically. As a byproduct, it also moves thes `IndexTemplateRegistry` to use an `initialize()` method so that constructors are not tempted to use a `this` reference in the constructor (see elastic#37861 for more information about why to avoid that). Resolves elastic#62835
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Features) |
elasticmachine
added
the
Team:Data Management
andreidan
approved these changes
Oct 16, 2020
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this Lee
x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/IndexLifecycle.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/IndexLifecycle.java
Outdated
Show resolved
Hide resolved
| this.stackTemplateEnabled = true; | ||
| } else { | ||
| logger.info( | ||
| "stack composable templates [{}] and component templates [{}] will not be installed or reinstalled", |
Contributor
There was a problem hiding this comment.
I think this is a bit confusing as to why this happened. Should we also mention that the setting was updated and as a result, the templates will not be installed/reinstalled anymore?
Member
Author
There was a problem hiding this comment.
the settings infrastructure already logs a message to that effect, so this looks like:
[2020-10-16T09:16:27,285][INFO ][o.e.c.s.ClusterSettings ] [runTask-0] updating [stack.templates.enabled] from [true] to [false]
[2020-10-16T09:16:27,286][INFO ][o.e.x.s.StackTemplateRegistry] [runTask-0] stack composable templates [logs,metrics,synthetics] and component templates [logs-mappings,logs-settings,metrics-mappings,metrics-settings,synthetics-mappings,synthetics-settings] will not be installed or reinstalled
That's why I left out any mention that the setting was updated (it happens regardless)
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Oct 16, 2020
* Make stack.templates.enabled a dynamic setting This change allows the setting for disabling the automatically installed stack templates (the `logs-*-*`, `metrics-*-*`, and `synthetics-*-*` templates) to be changed dynamically. As a byproduct, it also moves thes `IndexTemplateRegistry` to use an `initialize()` method so that constructors are not tempted to use a `this` reference in the constructor (see elastic#37861 for more information about why to avoid that). Resolves elastic#62835
dakrone
added a commit
that referenced
this pull request
Oct 16, 2020
* Make stack.templates.enabled a dynamic setting This change allows the setting for disabling the automatically installed stack templates (the `logs-*-*`, `metrics-*-*`, and `synthetics-*-*` templates) to be changed dynamically. As a byproduct, it also moves thes `IndexTemplateRegistry` to use an `initialize()` method so that constructors are not tempted to use a `this` reference in the constructor (see #37861 for more information about why to avoid that). Resolves #62835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the setting for disabling the automatically installed stack templates (the
logs-*-*,metrics-*-*, andsynthetics-*-*templates) to be changed dynamically.As a byproduct, it also moves thes
IndexTemplateRegistryto use aninitialize()method so thatconstructors are not tempted to use a
thisreference in the constructor (see #37861 and #38560for more information about why we want to avoid that).
Resolves #62835