Make array value parsing flag more robust. #63354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constructing a value fetcher, the 'parsesArrayValue' flag must match `FieldMapper#parsesArrayValue`. However there is nothing in code or tests to help enforce this. This PR reworks the value fetcher constructors so that `parsesArrayValue` is 'false' by default. Just as for `FieldMapper#parsesArrayValue`, field types must explicitly set it to true and ensure the behavior is covered by tests. Follow-up to elastic#62974.
jtibshirani
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
nik9000
reviewed
Oct 6, 2020
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Makes sense to me! I'll let @romseygeek review because it sounds like he understands the problem better.
romseygeek
approved these changes
Oct 6, 2020
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, much nicer. Thanks @jtibshirani!
Contributor
Author
|
Thank you both for the reviews ! |
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Oct 6, 2020
When constructing a value fetcher, the 'parsesArrayValue' flag must match `FieldMapper#parsesArrayValue`. However there is nothing in code or tests to help enforce this. This PR reworks the value fetcher constructors so that `parsesArrayValue` is 'false' by default. Just as for `FieldMapper#parsesArrayValue`, field types must explicitly set it to true and ensure the behavior is covered by tests. Follow-up to elastic#62974.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing a value fetcher, the 'parsesArrayValue' flag must match
FieldMapper#parsesArrayValue. However there is nothing in code or tests tohelp enforce this.
This PR splits out a class
ArraySourceValueFetcherthat handles array valuesdirectly and removes the flag. That way most field types can use the default
SourceValueFetcher. Field types that handle array values opt to useArraySourceValueFetcherand ensure the behavior is covered by tests.Follow-up to #62974.