Skip to content

Add assert that raw and readable xcontent field names are different #63332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add assert that raw and readable xcontent field names are different #63332

merged 1 commit into from
Oct 6, 2020

Conversation

@dakrone
Copy link
Member

@dakrone dakrone commented Oct 6, 2020

This adds asserts that will catch the case where we accidentally provide the same raw and readable
field name in xcontent.

@dakrone
Add assert that raw and readable xcontent field names are different
33af23a 
This adds asserts that will catch the case where we accidentally provide the same raw and readable
field name in xcontent.
@dakrone dakrone added >non-issue :Core/Infra/REST API REST infrastructure and utilities v8.0.0 v7.10.0 labels Oct 6, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 6, 2020

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 6, 2020
@dakrone
Copy link
Member Author

dakrone commented Oct 6, 2020

@elasticmachine run elasticsearch-ci/packaging-sample-windows

rjernst
rjernst approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone dakrone merged commit 7620e94 into elastic:master Oct 6, 2020
@dakrone dakrone deleted the xcontent-assert-on-same-name branch October 6, 2020 16:52
@dakrone
Copy link
Member Author

dakrone commented Oct 6, 2020

Thanks Ryan!

@dakrone dakrone mentioned this pull request Oct 6, 2020
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Oct 6, 2020
@dakrone
Add assert that raw and readable xcontent field names are different (e…
ecdffbb 
…lastic#63332)

This adds asserts that will catch the case where we accidentally provide the same raw and readable
field name in xcontent.
dakrone added a commit that referenced this pull request Oct 6, 2020
@dakrone
[7.x] Add assert that raw and readable xcontent field names are diffe…
dd99125 
…rent (#63332) (#63343)

This adds asserts that will catch the case where we accidentally provide the same raw and readable
field name in xcontent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst approved these changes

Assignees

No one assigned

Labels

:Core/Infra/REST API REST infrastructure and utilities >non-issue Team:Core/Infra Meta label for core/infra team v7.10.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dakrone @elasticmachine @rjernst @jakelandis