Remove MapperService argument from IndexFieldData.Builder#build #63197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapperService carries a lot of weight and is only used to determine if loading of field data for the id field is enabled, which can be done in a different way. There was another usage that recently went away with the removal of `TypeFieldMapper`.
javanna
added
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
Member
Author
|
I would love to backport this to 7.x but I haven't come up with a way to get the type in |
romseygeek
approved these changes
Oct 3, 2020
romseygeek
added a commit
that referenced
this pull request
Oct 6, 2020
In 6x and 7x, indexes can have only one type, which means that we can rework all queries against the type field to use a ConstantFieldType. This has already been done in master with the removal of the TypeFieldMapper, but we still need that class in 7x to deal with nested documents. This commit leaves TypeFieldMapper in place, but refactors TypeFieldType to extend ConstantFieldType and consolidates deprecation warnings within that class. It also incidentally removes the requirement to pass a MapperService to IndexFieldData.Builder#build, which should allow #63197 to be backported.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Oct 6, 2020
…tic#63197) MapperService carries a lot of weight and is only used to determine if loading of field data for the id field is enabled, which can be done in a different way. There was another usage that recently went away with the removal of `TypeFieldMapper`.
javanna
added a commit
that referenced
this pull request
Oct 6, 2020
…) (#63311) MapperService carries a lot of weight and is only used to determine if loading of field data for the id field is enabled, which can be done in a different way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapperService carries a lot of weight and is only used to determine if loading of field data for the id field is enabled, which can be done in a different way. There was another usage that recently went away with the removal of
TypeFieldMapper.