Skip to content

[Transform] fix time rounding in TransformContinuousIT #63113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020
Merged

[Transform] fix time rounding in TransformContinuousIT #63113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .../java/org/elasticsearch/xpack/transform/integration/continuous/TransformContinuousIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,10 @@ public void testContinousEvents() throws Exception {

// start all transforms, wait until the processed all data and stop them
startTransforms();
waitUntilTransformsReachedUpperBound(runDate.getEpochSecond() * 1000 + 1);

// at random we added between 0 and 999_999ns == (1ms - 1ns) to every data point, so we add 1ms, so every data point is before
// the checkpoint
waitUntilTransformsReachedUpperBound(runDate.toEpochMilli() + 1, run);
stopTransforms();

// TODO: the transform dest index requires a refresh, see gh#51154
Expand Down Expand Up @@ -387,11 +390,12 @@ private GetTransformStatsResponse getTransformStats(String id) throws IOExceptio
}
}

private void waitUntilTransformsReachedUpperBound(long timeStampUpperBoundMillis) throws Exception {
private void waitUntilTransformsReachedUpperBound(long timeStampUpperBoundMillis, int iteration) throws Exception {
logger.info(
"wait until transform reaches timestamp_millis: {}",
"wait until transform reaches timestamp_millis: {} iteration: {}",
ContinuousTestCase.STRICT_DATE_OPTIONAL_TIME_PRINTER_NANOS.withZone(ZoneId.of("UTC"))
.format(Instant.ofEpochMilli(timeStampUpperBoundMillis))
.format(Instant.ofEpochMilli(timeStampUpperBoundMillis)),
iteration
);
for (ContinuousTestCase testCase : transformTestCases) {
assertBusy(() -> {
Expand Down