[ML] all multiple wildcard values for GET Calendars, Events, and DELETE forecasts #62563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
davidkyle
approved these changes
Sep 18, 2020
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM
Thanks for all the tests
| /** | ||
| * Helper function for adding OR type queries for a given identity field. | ||
| * | ||
| * This adds a new filter to the passed `boolQueryBuilder`. |
Member
There was a problem hiding this comment.
Suggested change
| * This adds a new filter to the passed `boolQueryBuilder`. |
| return this; | ||
| } | ||
|
|
||
| public ResultsFilterBuilder resourceTokenFilers(String fieldName, String[] tokens) { |
Member
There was a problem hiding this comment.
Suggested change
| public ResultsFilterBuilder resourceTokenFilers(String fieldName, String[] tokens) { | |
| public ResultsFilterBuilder resourceTokenFilters(String fieldName, String[] tokens) { |
| pageParams = PageParams.defaultParams(); | ||
| } | ||
| getCalendars(pageParams, listener); | ||
| final String[] calendarIds = Strings.splitStringByCommaToArray(request.getCalendarId()); |
Member
There was a problem hiding this comment.
The GET request docs will need updating to add the standard description of a wildcard-able ID parameter
"comma-separated list of calendar Ids and wildcard expressions. You can get all by using _all, or * or by omitting the ID"
Member
Author
|
@elasticmachine update branch |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Sep 18, 2020
…TE forecasts (elastic#62563) This commit adjusts the following APIs so now they not only support an `_all` case, but wildcard patterned Ids as well. - `GET _ml/calendars/<calendar_id>/events` - `GET _ml/calendars/<calendar_id>` - `GET _ml/anomaly_detectors/<job_id>/model_snapshots/<snapshot_id>` - `DELETE _ml/anomaly_detectors/<job_id>/_forecast/<forecast_id>`
benwtrent
added a commit
that referenced
this pull request
Sep 18, 2020
…TE forecasts (#62563) (#62629) This commit adjusts the following APIs so now they not only support an `_all` case, but wildcard patterned Ids as well. - `GET _ml/calendars/<calendar_id>/events` - `GET _ml/calendars/<calendar_id>` - `GET _ml/anomaly_detectors/<job_id>/model_snapshots/<snapshot_id>` - `DELETE _ml/anomaly_detectors/<job_id>/_forecast/<forecast_id>`
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the following APIs so now they not only support an
_allcase, but wildcard patterned Ids as well.GET _ml/calendars/<calendar_id>/eventsGET _ml/calendars/<calendar_id>GET _ml/anomaly_detectors/<job_id>/model_snapshots/<snapshot_id>DELETE _ml/anomaly_detectors/<job_id>/_forecast/<forecast_id>