Skip to content

Fix test error in InternalCardinalityTests#testEqualsAndHashcode #62542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Fix test error in InternalCardinalityTests#testEqualsAndHashcode #62542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7c09c2
Make sure the the new HLL++ is different to the original one
iverase Sep 17, 2020
c762173
Merge branch 'master' into fixCardinalityTest
iverase Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...src/test/java/org/elasticsearch/search/aggregations/metrics/InternalCardinalityTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,7 @@ protected InternalCardinality mutateInstance(InternalCardinality instance) {
case 1:
HyperLogLogPlusPlus newState = new HyperLogLogPlusPlus(state.precision(),
new MockBigArrays(new MockPageCacheRecycler(Settings.EMPTY), new NoneCircuitBreakerService()), 0);
newState.merge(0, state, 0);
int extraValues = between(10, 100);
for (int i = 0; i < extraValues; i++) {
for (int i = 0; i < 10; i++) {
newState.collect(0, BitMixer.mix64(randomIntBetween(500, 10000)));
Copy link
Contributor

@polyfractal polyfractal Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked closely at the test, but is there a way to ensure we add new values that weren't previously added? Maybe by picking from a different range of random values or something? Or keeping a set?

Maybe it's a non-issue and random enough to not matter... might be a problem for a different day :)

Copy link
Contributor Author

@iverase iverase Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does use a different range of values, Still for precision 4 in the previous approach you could get the same sketch at the end :( I think this way is very very unlikely.

Copy link
Contributor

@polyfractal polyfractal Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah gotcha. Sounds good!

}
algos.add(newState);
Expand Down