Prohibit the usage of create index api in namespaces managed by data stream templates #62527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stream templates. This commit adds validation that prohibits the creation of regular indices in the namespace of templates with data streams enabled. It shouldn't be possible to create ordinary indices when the name of the index matches with a composable index template that enables data streams. Auto creation has logic that creates data streams instead of regular indices. However validation logic for the create index api was missing.
martijnvg
added
>bug
v8.0.0
:Data Management/Data streams
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Data streams) |
elasticmachine
added
the
Team:Data Management
dakrone
approved these changes
Sep 17, 2020
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left one suggestion for the error message
| ComposableIndexTemplate template = currentState.getMetadata().templatesV2().get(templateName); | ||
| if (request.dataStreamName() == null && template.getDataStreamTemplate() != null) { | ||
| throw new IllegalArgumentException("cannot create index with name [" + request.index() + | ||
| "], because it matches with template [" + templateName + "] that creates data streams only"); |
Member
There was a problem hiding this comment.
I think we should try to steer the user in the right direction, can we suggest they try the create data stream API in the error message?
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 17, 2020
…stream templates Backport of elastic#62527 to 7.x branch. This commit adds validation that prohibits the creation of regular indices in the namespace of templates with data streams enabled. It shouldn't be possible to create ordinary indices when the name of the index matches with a composable index template that enables data streams. Auto creation has logic that creates data streams instead of regular indices. However validation logic for the create index api was missing.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 17, 2020
…stream templates Backport of elastic#62527 to 7.9 branch. This commit adds validation that prohibits the creation of regular indices in the namespace of templates with data streams enabled. It shouldn't be possible to create ordinary indices when the name of the index matches with a composable index template that enables data streams. Auto creation has logic that creates data streams instead of regular indices. However validation logic for the create index api was missing.
martijnvg
added a commit
that referenced
this pull request
Sep 17, 2020
…stream templates (#62574) Backport of #62527 to 7.x branch. This commit adds validation that prohibits the creation of regular indices in the namespace of templates with data streams enabled. It shouldn't be possible to create ordinary indices when the name of the index matches with a composable index template that enables data streams. Auto creation has logic that creates data streams instead of regular indices. However validation logic for the create index api was missing.
martijnvg
added a commit
that referenced
this pull request
Sep 18, 2020
…stream templates (#62575) Backport of #62527 to 7.9 branch. This commit adds validation that prohibits the creation of regular indices in the namespace of templates with data streams enabled. It shouldn't be possible to create ordinary indices when the name of the index matches with a composable index template that enables data streams. Auto creation has logic that creates data streams instead of regular indices. However validation logic for the create index api was missing. * adjust docs test to not index into stack template namespace. (test was disabled on 7.x and master branches)
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 18, 2020
after elastic#62527 was backported.
martijnvg
added a commit
that referenced
this pull request
Sep 18, 2020
after #62527 was backported.
martijnvg
added a commit
that referenced
this pull request
Sep 18, 2020
after #62527 was backported.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 18, 2020
after elastic#62527 was backported.
martijnvg
added a commit
that referenced
this pull request
Sep 18, 2020
after #62527 was backported.
martijnvg
added a commit
that referenced
this pull request
Sep 18, 2020
after #62527 was backported.
martijnvg
added a commit
that referenced
this pull request
Sep 18, 2020
after #62527 was backported.
martijnvg
added a commit
that referenced
this pull request
Sep 18, 2020
after #62527 was backported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds validation that prohibits the creation of regular indices
in the namespace of templates with data streams enabled.
It shouldn't be possible to create ordinary indices when the name of the index
matches with a composable index template that enables data streams. Auto creation
has logic that creates data streams instead of regular indices. However validation
logic for the create index api was missing.