Only call reduce on a single InternalAggregation when needed #62525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
Contributor
Author
|
I am actually wondering if reduce on a single egg should take into account Nope, it break tests |
nik9000
approved these changes
Sep 17, 2020
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Sure! It is a shame to have another method to remember to deal with but it looks like mostly the default implementation is correct.
Member
I mean that most new aggs can just accept the default implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always call reduce even when we only have one InternalAggregation. In some cases this is necessary but in others the reduce method is just making a copy of itself. This is normally not too expensive excepts for aggregations that hold expensive objects, for example cardinality or percentile aggregations.
In order to prevent this necessary step this PR adds a new abstract method in InternalAggregation that flags the framework if it needs to reduce on a single InternalAggregation.