Fix docvalue fetch for scaled floats #62425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#61995 I moved the `docvalue_field` fetch code into a place where I could share it with the fancy new `fields` fetch API. Specifically, runtime fields can use it all that doc values code now. But I broke `scaled_floats` by switching them how they are fetched from `double` to `string`. This adds the override you need to switch them back.
nik9000
added
>non-issue
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Member
Author
javanna
reviewed
Sep 16, 2020
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
thanks Nik, and I thought I double checked that all the field types still worked correctly :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #61995 I moved the
docvalue_fieldfetch code into a place where Icould share it with the fancy new
fieldsfetch API. Specifically,runtime fields can use it all that doc values code now. But I broke
scaled_floatsby switching them how they are fetched fromdoubletostring. This adds the override you need to switch them back.