Optimize extra global check points in BlobStoreIndexShardSnapshots. #62285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
Contributor
|
Jenkins test this |
original-brownbear
approved these changes
Sep 14, 2020
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, thanks @howardhuanghua
Contributor
Author
|
Some tests failed? It seems it's based on the latest master branch. |
Contributor
|
@howardhuanghua yea it's caused by #62286, we'll have to retriever the build once that's merged. |
Contributor
|
@howardhuanghua could you merge latest master into this branch so we get a green CI run? Thanks! |
Contributor
Author
|
done. |
Contributor
|
Jenkins test this |
Contributor
|
Jenkins run elasticsearch-ci/packaging-sample-windows |
original-brownbear
pushed a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 14, 2020
This was never used.
original-brownbear
added a commit
that referenced
this pull request
Sep 14, 2020
This was never used. Co-authored-by: Howard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unused global check points HashMap instance to lower down memory fingerprint.
It's introduced in #52182 v7.7.0.