Release search context when scroll keep_alive is too large #62179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
This reverts commit 7af2fec.
dnhatn
added
>non-issue
and removed
>test
dnhatn
changed the title
Member
Author
|
@jimczi I've updated the PR. |
jimczi
approved these changes
Sep 9, 2020
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
I left a small comments but the fix looks good to me.
server/src/main/java/org/elasticsearch/search/SearchService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/SearchService.java
Outdated
Show resolved
Hide resolved
jimczi
approved these changes
Sep 9, 2020
Member
Author
|
Thanks Jim! |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Sep 10, 2020
…2179) Previously, we close related search contexts if the keep_alive of a scroll is too large. But we accidentally change this behavior in elastic#62061.
dnhatn
added a commit
that referenced
this pull request
Sep 10, 2020
Previously, we close related search contexts if the keep_alive of a scroll is too large. But we accidentally change this behavior in #62061.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we close related search contexts if the keep_alive of a scroll is too large. But we accidentally change this behavior in #62061.
CI: https://gradle-enterprise.elastic.co/s/f2aczys5rxvik/console-log/raw