[ML] Add support for date_nanos fields in find_file_structure #62048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that elastic#61324 is merged it is possible for the find_file_structure endpoint to suggest using date_nanos fields for timestamps where the timestamp format provides greater than millisecond accuracy.
Collaborator
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
approved these changes
Sep 7, 2020
Contributor
przemekwitek
left a comment
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
Just one minor style nit and one question.
...ugin/ml/src/main/java/org/elasticsearch/xpack/ml/filestructurefinder/FileStructureUtils.java
Outdated
Show resolved
Hide resolved
| int consecutiveSs = 0; | ||
| for (int pos = 0; pos < format.length(); ++pos) { | ||
| char curChar = format.charAt(pos); | ||
| if (curChar == '\'') { |
Contributor
There was a problem hiding this comment.
Just double-checking: can there be a quotation inside another quotation?
Author
There was a problem hiding this comment.
A literal ' is specified by two consecutive single quotes - see https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html. This means that no special logic is needed in this method. If there is a literal single quote then this method will treat it as an empty literal section, which is technically wrong but achieves the desired effect.
But since this is quite subtle I will add a comment to say what is going on.
…structurefinder/FileStructureUtils.java Co-authored-by: Przemysław Witek <[email protected]>
…95/elasticsearch into date_nanos_in_structure_finder
droberts195
pushed a commit
that referenced
this pull request
Sep 8, 2020
Now that #61324 is merged it is possible for the find_file_structure endpoint to suggest using date_nanos fields for timestamps where the timestamp format provides greater than millisecond accuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #61324 is merged it is possible for the find_file_structure
endpoint to suggest using date_nanos fields for timestamps where
the timestamp format provides greater than millisecond accuracy.