Add specific test for serializing all mapping parameter values #61844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>non-issue
>test
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
Contributor
Author
|
Marked as |
nik9000
approved these changes
Sep 2, 2020
|
|
||
| @Override | ||
| public void testMinimalToMaximal() { | ||
| // `include_defaults` includes unsupported properties in non-parametrized mappers |
Member
There was a problem hiding this comment.
Could you assumeFalse here so it logs as skipped? I don't think that makes a big difference in the long run, but it makes me feel a little better about doing nothing in a test.
romseygeek
added a commit
to romseygeek/elasticsearch
that referenced
this pull request
Sep 2, 2020
…ic#61844) This commit adds a test to MapperTestCase that explicitly checks that a mapper can serialize all its default values, and that this serialization can then be re-parsed. Note that the test is disabled for non-parametrized mappers as their serialization may in some cases output parameters that are not accepted. Gradually moving all mappers to parametrized form will address this. The commit also contains a fix to keyword mappers, which were not correctly serializing the similarity parameter; this partially addresses elastic#61563. It also enables `null` as a value for `null_value` on `scaled_float`, as a follow-up to elastic#61798
romseygeek
added a commit
that referenced
this pull request
Sep 3, 2020
… (#61877) This commit adds a test to MapperTestCase that explicitly checks that a mapper can serialize all its default values, and that this serialization can then be re-parsed. Note that the test is disabled for non-parametrized mappers as their serialization may in some cases output parameters that are not accepted. Gradually moving all mappers to parametrized form will address this. The commit also contains a fix to keyword mappers, which were not correctly serializing the similarity parameter; this partially addresses #61563. It also enables `null` as a value for `null_value` on `scaled_float`, as a follow-up to #61798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a test to
MapperTestCasethat explicitly checks that a mapper canserialize all its default values, and that this serialization can then be re-parsed. Note that
the test is disabled for non-parametrized mappers as their serialization may in some cases
output parameters that are not accepted. Gradually moving all mappers to parametrized
form will address this.
The commit also contains a fix to keyword mappers, which were not correctly serializing
the
similarityparameter; this partially addresses #61563